tranpl/redcap-api
1
1
Fork 0
Code Issues 4 Pull requests Projects Releases 25 Packages Wiki Activity Actions

Added CancellationToken optional parameter to all IO async functions #118

Merged
jonny-ibdr merged 1 commit from master into master 2023-09-16 13:50:49 -04:00
Conversation 1 Commits 1 Files changed 3 +615 -396
jonny-ibdr commented 2023-08-31 11:47:03 -04:00 (Migrated from github.com)
Copy link

I have noticed that none of the functions within this library accepted CancellationToken as a parameter. CancellationTokens are extremely common in asynchronous programming, and is best practice to include them.

Just some notes on the ConvertIntArraytoString function - this shouldn't be async, as it will run synchronously anyway, you can just return the string instead of Task<string>. Let me know if you would like me to refactor this in the same pull request.

I have noticed that none of the functions within this library accepted CancellationToken as a parameter. CancellationTokens are extremely common in asynchronous programming, and is best practice to include them. Just some notes on the ConvertIntArraytoString function - this shouldn't be async, as it will run synchronously anyway, you can just return the ``string`` instead of ``Task<string>``. Let me know if you would like me to refactor this in the same pull request.
cctrbic (Migrated from github.com) approved these changes 2023-09-16 13:50:44 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
cctrbic
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tranpl/redcap-api!118
No description provided.